Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/22130 )
Change subject: IMPALA-13565: Add general AI platform support to ai_generate_text ...................................................................... Patch Set 8: (6 comments) http://gerrit.cloudera.org:8080/#/c/22130/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22130/7//COMMIT_MSG@9 PS7, Line 9: OpenAI > for clarity mention 'OpenAI' single word Done http://gerrit.cloudera.org:8080/#/c/22130/7//COMMIT_MSG@30 PS7, Line 30: 5MB > Maybe make this an advanced flagfile option with default value 5M, in case Yeah, I can follow this in another Jira. http://gerrit.cloudera.org:8080/#/c/22130/7/be/src/exprs/ai-functions-ir.cc File be/src/exprs/ai-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/22130/7/be/src/exprs/ai-functions-ir.cc@46 PS7, Line 46: DEFINE_string(ai_additional_platforms, "", > I think we should rename this to "ai_additional_platforms"? Done http://gerrit.cloudera.org:8080/#/c/22130/7/be/src/exprs/ai-functions.inline.h File be/src/exprs/ai-functions.inline.h: http://gerrit.cloudera.org:8080/#/c/22130/7/be/src/exprs/ai-functions.inline.h@160 PS7, Line 160: headers.emplace_back(OPEN_AI_REQUEST_FIELD_CONTENT_TYPE_HEADER); : string authHeader; : AiFunctions::AiFunctionsOptions ai_options; : Document impala_options_document; : : i > We should put this block inside 'if(!fastpath)' Done http://gerrit.cloudera.org:8080/#/c/22130/7/be/src/exprs/ai-functions.inline.h@169 PS7, Line 169: LOG(WARNING) << AI_GENERATE_TXT_JSON_PARSE_ERROR << ": " << e.what(); : return StringVal(AI_GENERATE_TXT_JSON_PARSE_ERROR.c_str()); : } : } > When using plain text secret/token we shouldn't create a copy and we can ma Done, also changed the getAuthorizationHeader() function. http://gerrit.cloudera.org:8080/#/c/22130/7/be/src/exprs/ai-functions.inline.h@192 PS7, Line 192: } > skip the if block for fastpath Done -- To view, visit http://gerrit.cloudera.org:8080/22130 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4ea2e1946089f262dda7ace73d5f7e37a5c98b14 Gerrit-Change-Number: 22130 Gerrit-PatchSet: 8 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anonymous Coward (801) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 14 Jan 2025 02:04:54 +0000 Gerrit-HasComments: Yes
