Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10479 )

Change subject: IMPALA-6953: part 2: clean up DiskIoMgr
......................................................................


Patch Set 2: Code-Review+2

(2 comments)

carry

http://gerrit.cloudera.org:8080/#/c/10479/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10479/1//COMMIT_MSG@11
PS1, Line 11: Made further mechanical changes that involved a lot of code 
motion:
> Both of these changes make sense on their own, so i don't see the need to s
Ok, I'll merge separately.


http://gerrit.cloudera.org:8080/#/c/10479/1//COMMIT_MSG@15
PS1, Line 15: Remove some unused member
> whats that?
lol, done



--
To view, visit http://gerrit.cloudera.org:8080/10479
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie82849652266b6660dd479689e5134273b172eb5
Gerrit-Change-Number: 10479
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Wed, 23 May 2018 04:20:02 +0000
Gerrit-HasComments: Yes

Reply via email to