Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22360 )
Change subject: IMPALA-13678: Validate remote_submit_time against coordinator time ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/22360/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22360/2//COMMIT_MSG@15 PS2, Line 15: nim > "minimum" would be better, "min" could also refer to "minute". Done http://gerrit.cloudera.org:8080/#/c/22360/2/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/22360/2/be/src/service/client-request-state.cc@216 PS2, Line 216: void ClientRequestState::SetRemoteSubmitTime(int64_t remote_submit_time) { > Could you mention this new behaviour in the function comment in the .h file Done -- To view, visit http://gerrit.cloudera.org:8080/22360 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6e04219c515fddff07bfbee43bb93babb3d307b Gerrit-Change-Number: 22360 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 20 Jan 2025 18:53:38 +0000 Gerrit-HasComments: Yes
