Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/22360 )
Change subject: IMPALA-13678: Validate remote_submit_time against coordinator time ...................................................................... Patch Set 3: (1 comment) Thanks Riza! I have one last question. But the suggestion is only optional. http://gerrit.cloudera.org:8080/#/c/22360/3/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/22360/3/be/src/service/client-request-state.cc@217 PS3, Line 217: int64_t ack_submit_time = min(MonotonicStopWatch::Now(), remote_submit_time) Sorry I have one last question. Thanks! I was wondering if it would be a good idea to log the incident where 'remote_submit_time' is too far ahead of 'MonotonicStopWatch::Now()' since this is an indication of clock skew among machines on the same cluster where the Impala service is running. -- To view, visit http://gerrit.cloudera.org:8080/22360 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6e04219c515fddff07bfbee43bb93babb3d307b Gerrit-Change-Number: 22360 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 20 Jan 2025 19:48:49 +0000 Gerrit-HasComments: Yes
