Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/22368 )
Change subject: IMPALA-13680: Avoid flush() when closing TSSLSocket ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/22368/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22368/1//COMMIT_MSG@18 PS1, Line 18: TBufferedTranspor > It is a subclass for TBufferedTransport, right? Which we call BufferedTrans yes, done http://gerrit.cloudera.org:8080/#/c/22368/1/be/src/rpc/thrift-server.h File be/src/rpc/thrift-server.h: http://gerrit.cloudera.org:8080/#/c/22368/1/be/src/rpc/thrift-server.h@94 PS1, Line 94: virtual std::shared_ptr<apache::thrift::transport::TTransport> getTransport( > Is it intentional that 'virtual' is removed here? thanks for spotting, it was by mistake -- To view, visit http://gerrit.cloudera.org:8080/22368 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4879a1567f7691711d73287269bf87f2946e75d2 Gerrit-Change-Number: 22368 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 22 Jan 2025 18:08:44 +0000 Gerrit-HasComments: Yes
