Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22368 )
Change subject: IMPALA-13680: Avoid flush() when closing TSSLSocket ...................................................................... Patch Set 3: (1 comment) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22368/3/be/src/rpc/thrift-server.h File be/src/rpc/thrift-server.h: http://gerrit.cloudera.org:8080/#/c/22368/3/be/src/rpc/thrift-server.h@74 PS3, Line 74: // https://github.com/apache/thrift/blob/d078721e44fea7713832ae5d0f5d9ca67317f19e/lib/cpp/src/thrift/transport/TBufferTransports.h#L367 line too long (141 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22368 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4879a1567f7691711d73287269bf87f2946e75d2 Gerrit-Change-Number: 22368 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 24 Jan 2025 18:21:35 +0000 Gerrit-HasComments: Yes
