Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22367 )
Change subject: IMPALA-13654: Tolerate missing data files of Iceberg tables ...................................................................... Patch Set 2: (2 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/22367/1/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/22367/1/tests/query_test/test_iceberg.py@1609 PS1, Line 1609: "select snapshot_id from {}.`snapshots` order by committed_at".format(tbl)) > At least theoretically, the order of rows is not guaranteed. We could sort Done http://gerrit.cloudera.org:8080/#/c/22367/1/tests/query_test/test_iceberg.py@1647 PS1, Line 1647: iceberg-missing-data-files > Does this test file exist? Done -- To view, visit http://gerrit.cloudera.org:8080/22367 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If753619d8ee1b30f018e90157ff7bdbe5d7f1525 Gerrit-Change-Number: 22367 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 22 Jan 2025 20:17:27 +0000 Gerrit-HasComments: Yes
