Daniel Becker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22367 )

Change subject: IMPALA-13654: Tolerate missing data files of Iceberg tables
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

Just one question, otherwise LGTM.

http://gerrit.cloudera.org:8080/#/c/22367/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-missing-data-files.test
File 
testdata/workloads/functional-query/queries/QueryTest/iceberg-missing-data-files.test:

http://gerrit.cloudera.org:8080/#/c/22367/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-missing-data-files.test@16
PS2, Line 16: cache
Why is it "cache"? I think it may be confusing. Is it hard to make this message 
more informative?



--
To view, visit http://gerrit.cloudera.org:8080/22367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If753619d8ee1b30f018e90157ff7bdbe5d7f1525
Gerrit-Change-Number: 22367
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Tue, 04 Feb 2025 12:48:12 +0000
Gerrit-HasComments: Yes

Reply via email to