Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22378 )
Change subject: IMPALA-13677: Add startup cleanup for remote scratch ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/22378/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22378/2//COMMIT_MSG@21 PS2, Line 21: This design assumes one Impala daemon per host. Could this be extended to multiple impalads per host, for example by checking whether the impalad belonging to the backend_id is alive before deleting its scratch directory? It could happen that there are two impalads on a host, impalad1 participates in a query, impalad2 doesn't, then impalad2 is restarted, the whole scratch space is deleted, so impalad1 will not find its scratch files. http://gerrit.cloudera.org:8080/#/c/22378/2/be/src/runtime/tmp-file-mgr.cc File be/src/runtime/tmp-file-mgr.cc: http://gerrit.cloudera.org:8080/#/c/22378/2/be/src/runtime/tmp-file-mgr.cc@882 PS2, Line 882: tmp_mgr->RemoveRemoteDirForHost(path_, hdfs_conn); Will this delete the directory itself or only its contents? -- To view, visit http://gerrit.cloudera.org:8080/22378 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iadd49b7384d52bac5ddab4e86cd9f39dc2c88e1b Gerrit-Change-Number: 22378 Gerrit-PatchSet: 2 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 23 Jan 2025 14:07:41 +0000 Gerrit-HasComments: Yes
