Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/22378 )
Change subject: IMPALA-13677: Add startup cleanup for remote scratch ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/22378/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22378/3//COMMIT_MSG@7 PS3, Line 7: IMPALA-13677: Add startup cleanup for remote scratch Maybe rephrase this to: "Support remote scratch directory cleanup at Impala daemon startup" http://gerrit.cloudera.org:8080/#/c/22378/3//COMMIT_MSG@21 PS3, Line 21: removed entirely. This design assumes one Impala daemon per host. Maybe we should also mention other assumptions: This design also assumes that multiple Impala clusters don't share the same scratch_dir path on remote filesystem. Even if they share the same prefix, each Impala cluster should have dedicated paths: --scratch_dirs=hdfs://remote_dir/scratch/impala1 --scratch_dirs=hdfs://remote_dir/scratch/impala2 http://gerrit.cloudera.org:8080/#/c/22378/3/be/src/runtime/io/disk-io-mgr.cc File be/src/runtime/io/disk-io-mgr.cc: http://gerrit.cloudera.org:8080/#/c/22378/3/be/src/runtime/io/disk-io-mgr.cc@406 PS3, Line 406: LOG(INFO) << "File upload succeeded. File name: " << remote_file_path; Should this be at INFO level? Logging at each 256M (default) file upload could result in excessive logging. http://gerrit.cloudera.org:8080/#/c/22378/3/be/src/runtime/tmp-file-mgr.cc File be/src/runtime/tmp-file-mgr.cc: http://gerrit.cloudera.org:8080/#/c/22378/3/be/src/runtime/tmp-file-mgr.cc@475 PS3, Line 475: string hostname = ExecEnv::GetInstance()->configured_backend_address().hostname; If this is IP address then this could change at startup. I'm not quite sure that this always returns a hostname and not IP address? -- To view, visit http://gerrit.cloudera.org:8080/22378 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iadd49b7384d52bac5ddab4e86cd9f39dc2c88e1b Gerrit-Change-Number: 22378 Gerrit-PatchSet: 3 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 24 Jan 2025 15:42:16 +0000 Gerrit-HasComments: Yes
