Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20447 )
Change subject: IMPALA-13039: AES Encryption/ Decryption Support in Impala ...................................................................... Patch Set 30: (4 comments) http://gerrit.cloudera.org:8080/#/c/20447/30/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/20447/30/be/src/exprs/string-functions-ir.cc@1828 PS30, Line 1828: ctx->AddWarning(Substitute("No AES mode was specified by user. Using $0 mode as default.", line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/20447/30/be/src/exprs/string-functions-ir.cc@1891 PS30, Line 1891: // If the mode passed by the user is supported by Impala (a valid member of AES_CIPHER_MODE line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/20447/30/be/src/exprs/string-functions-ir.cc@1895 PS30, Line 1895: // This is different from the case where the user enters a mode that Impala does not support line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/20447/30/tests/query_test/test_exprs.py File tests/query_test/test_exprs.py: http://gerrit.cloudera.org:8080/#/c/20447/30/tests/query_test/test_exprs.py@76 PS30, Line 76: d flake8: E303 too many blank lines (2) -- To view, visit http://gerrit.cloudera.org:8080/20447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3902f2b1d95da4d06995cbd687e79c48e16190c9 Gerrit-Change-Number: 20447 Gerrit-PatchSet: 30 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Comment-Date: Fri, 24 Jan 2025 04:45:57 +0000 Gerrit-HasComments: Yes
