Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20447 )
Change subject: IMPALA-13039: AES Encryption/ Decryption Support in Impala ...................................................................... Patch Set 31: (6 comments) http://gerrit.cloudera.org:8080/#/c/20447/31/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/20447/31/be/src/exprs/string-functions-ir.cc@22 PS31, Line 22: #include <openssl/bio.h> We no longer need the added includes on L22, 23, 25, 34, 38 and 41. http://gerrit.cloudera.org:8080/#/c/20447/31/be/src/exprs/string-functions.h File be/src/exprs/string-functions.h: http://gerrit.cloudera.org:8080/#/c/20447/31/be/src/exprs/string-functions.h@112 PS31, Line 112: Nit: unneeded space. http://gerrit.cloudera.org:8080/#/c/20447/31/be/src/exprs/string-functions.cc File be/src/exprs/string-functions.cc: http://gerrit.cloudera.org:8080/#/c/20447/31/be/src/exprs/string-functions.cc@38 PS31, Line 38: #include "udf/udf.h" This import is not needed. http://gerrit.cloudera.org:8080/#/c/20447/31/be/src/exprs/string-functions.cc@433 PS31, Line 433: *state = true; Here '*state' is already true. This should be in the IF block, but only when 'state' is not nullptr. Possibly as "if (state != nullptr) *state = true;" http://gerrit.cloudera.org:8080/#/c/20447/31/be/src/util/openssl-util-test.cc File be/src/util/openssl-util-test.cc: http://gerrit.cloudera.org:8080/#/c/20447/31/be/src/util/openssl-util-test.cc@160 PS31, Line 160: 12345678901 This is not AES_BLOCK_SIZE long, there will be a buffer overflow. Also on L163. http://gerrit.cloudera.org:8080/#/c/20447/31/testdata/workloads/functional-query/queries/QueryTest/encryption_exprs.test File testdata/workloads/functional-query/queries/QueryTest/encryption_exprs.test: http://gerrit.cloudera.org:8080/#/c/20447/31/testdata/workloads/functional-query/queries/QueryTest/encryption_exprs.test@448 PS31, Line 448: : : : Nit: unneeded empty lines. -- To view, visit http://gerrit.cloudera.org:8080/20447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3902f2b1d95da4d06995cbd687e79c48e16190c9 Gerrit-Change-Number: 20447 Gerrit-PatchSet: 31 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Comment-Date: Sat, 25 Jan 2025 00:59:57 +0000 Gerrit-HasComments: Yes
