Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21976 )
Change subject: IMPALA-13481: Add support for various agg and analytic functions ...................................................................... Patch Set 16: Code-Review+1 (3 comments) This is looking good, just a couple nits http://gerrit.cloudera.org:8080/#/c/21976/16/testdata/workloads/functional-query/queries/QueryTest/analytic-fns.test File testdata/workloads/functional-query/queries/QueryTest/analytic-fns.test: http://gerrit.cloudera.org:8080/#/c/21976/16/testdata/workloads/functional-query/queries/QueryTest/analytic-fns.test@a1552 PS16, Line 1552: : : : : : : : : : : : This test case got dropped http://gerrit.cloudera.org:8080/#/c/21976/16/testdata/workloads/functional-query/queries/QueryTest/analytic-fns.test@1431 PS16, Line 1431: t.r Nit: We can switch the t.r/t.c back to ((t.c-t.r)+1)/t.c (though it is the same in this circumstance) http://gerrit.cloudera.org:8080/#/c/21976/16/testdata/workloads/functional-query/queries/QueryTest/analytic-fns.test@1470 PS16, Line 1470: t.r/t.c Nit: ((t.c-t.r)+1)/t.c -- To view, visit http://gerrit.cloudera.org:8080/21976 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57c69a60c63872b2964688f395b662a85698555e Gerrit-Change-Number: 21976 Gerrit-PatchSet: 16 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Fri, 24 Jan 2025 17:47:30 +0000 Gerrit-HasComments: Yes
