Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21976 )
Change subject: IMPALA-13481: Add support for various agg and analytic functions ...................................................................... Patch Set 17: (2 comments) Couple things I didn't notice in the last round http://gerrit.cloudera.org:8080/#/c/21976/17/testdata/workloads/functional-query/queries/QueryTest/analytic-fns.test File testdata/workloads/functional-query/queries/QueryTest/analytic-fns.test: http://gerrit.cloudera.org:8080/#/c/21976/17/testdata/workloads/functional-query/queries/QueryTest/analytic-fns.test@1433 PS17, Line 1433: rank() over (partition by year, month order by id) as r, I think we flipped the order by (removing desc) and need to flip it back. http://gerrit.cloudera.org:8080/#/c/21976/17/testdata/workloads/functional-query/queries/QueryTest/analytic-fns.test@1472 PS17, Line 1472: rank() over (partition by year, month order by id desc) as r, I think this one would need to remove the "desc" -- To view, visit http://gerrit.cloudera.org:8080/21976 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57c69a60c63872b2964688f395b662a85698555e Gerrit-Change-Number: 21976 Gerrit-PatchSet: 17 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Fri, 24 Jan 2025 20:39:07 +0000 Gerrit-HasComments: Yes
