Pranav Lodha has posted comments on this change. ( http://gerrit.cloudera.org:8080/20447 )
Change subject: IMPALA-13039: AES Encryption/ Decryption Support in Impala ...................................................................... Patch Set 37: (9 comments) > Uploaded patch set 37. http://gerrit.cloudera.org:8080/#/c/20447/36/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/20447/36/be/src/exprs/string-functions-ir.cc@1937 PS36, Line 1937: // The state is a bool used to reduce excessive logs. > It could be noted that the state is simply a bool used to reduce log spew Done http://gerrit.cloudera.org:8080/#/c/20447/36/be/src/exprs/string-functions.cc File be/src/exprs/string-functions.cc: http://gerrit.cloudera.org:8080/#/c/20447/36/be/src/exprs/string-functions.cc@441 PS36, Line 441: StringPiece : (reinterpret_cast<const char*>(mode.ptr), mode.len)) > nit: There is a utility function to create an std::string from StringVal: h There were some comments about it in the previous patchsets. http://gerrit.cloudera.org:8080/#/c/20447/36/be/src/util/openssl-util.cc File be/src/util/openssl-util.cc: http://gerrit.cloudera.org:8080/#/c/20447/36/be/src/util/openssl-util.cc@a234 PS36, Line 234: > please don't remove this comment Done http://gerrit.cloudera.org:8080/#/c/20447/36/be/src/util/openssl-util.cc@270 PS36, Line 270: ScopedEVPCipherCtx ctx(padding_flag); > This is not new code, but I don't get why EVP_CIPHER_CTX_set_padding() is c There is some discussion about it in previous patchsets. http://gerrit.cloudera.org:8080/#/c/20447/36/be/src/util/openssl-util.cc@287 PS36, Line 287: EVP_DecryptInit_ex(ctx.ctx, evpCipher, nullptr, nullptr, nullptr); > nit: would be nice to EVP_EncryptInit_ex/EVP_DecryptInit_ex to be in differ Done http://gerrit.cloudera.org:8080/#/c/20447/36/be/src/util/openssl-util.cc@335 PS36, Line 335: > Same as for other encrypy : ? blocks Done http://gerrit.cloudera.org:8080/#/c/20447/36/be/src/util/openssl-util.cc@334 PS36, Line 334: EVP_DecryptFinal_ex(ctx.ctx, out + output_offset, &final_out_len); : : if (success != 1) { > nit: Unnecessary line breaks makes the code less legible. Please break line Done http://gerrit.cloudera.org:8080/#/c/20447/36/common/function-registry/impala_functions.py File common/function-registry/impala_functions.py: http://gerrit.cloudera.org:8080/#/c/20447/36/common/function-registry/impala_functions.py@525 PS36, Line 525: [['aes_encrypt'], 'STRING', ['STRING', 'STRING', 'STRING', 'STRING'], 'impala::StringFunctions::AesEncrypt', > nit: extra line Done http://gerrit.cloudera.org:8080/#/c/20447/36/testdata/workloads/functional-query/queries/QueryTest/encryption_exprs.test File testdata/workloads/functional-query/queries/QueryTest/encryption_exprs.test: http://gerrit.cloudera.org:8080/#/c/20447/36/testdata/workloads/functional-query/queries/QueryTest/encryption_exprs.test@67 PS36, Line 67: aes_decrypt(aes_encrypt( > Please cover the other way around, meaning decrypting first then encrypting Done -- To view, visit http://gerrit.cloudera.org:8080/20447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3902f2b1d95da4d06995cbd687e79c48e16190c9 Gerrit-Change-Number: 20447 Gerrit-PatchSet: 37 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Comment-Date: Mon, 27 Jan 2025 12:42:25 +0000 Gerrit-HasComments: Yes
