Pranav Lodha has posted comments on this change. ( http://gerrit.cloudera.org:8080/20447 )
Change subject: IMPALA-13039: AES Encryption/ Decryption Support in Impala ...................................................................... Patch Set 38: (6 comments) > Uploaded patch set 38. http://gerrit.cloudera.org:8080/#/c/20447/36/be/src/util/openssl-util-test.cc File be/src/util/openssl-util-test.cc: http://gerrit.cloudera.org:8080/#/c/20447/36/be/src/util/openssl-util-test.cc@81 PS36, Line 81: ASSERT_OK(key.InitializeRandom(AES_BLOCK_SIZE, m)); : > If we touch that part: Done http://gerrit.cloudera.org:8080/#/c/20447/36/be/src/util/openssl-util.cc File be/src/util/openssl-util.cc: http://gerrit.cloudera.org:8080/#/c/20447/36/be/src/util/openssl-util.cc@314 PS36, Line 314: // The OpenSSL encryption APIs use INT for buffer lengths. To support larger buffers, : // larger buffers need to be chunked into smaller parts. : int64_t output_offset = 0; > nit: would be more readable by breaking after EVP_EncryptUpdate - it could Done http://gerrit.cloudera.org:8080/#/c/20447/37/be/src/util/openssl-util.cc File be/src/util/openssl-util.cc: http://gerrit.cloudera.org:8080/#/c/20447/37/be/src/util/openssl-util.cc@286 PS37, Line 286: // on x86 and PowerPC. > line too long (92 > 90) Done http://gerrit.cloudera.org:8080/#/c/20447/37/be/src/util/openssl-util.cc@287 PS37, Line 287: > line too long (92 > 90) Done http://gerrit.cloudera.org:8080/#/c/20447/37/be/src/util/openssl-util.cc@314 PS37, Line 314: // The OpenSSL encryption APIs use INT for buffer lengths. To support larger buffers, > line too long (99 > 90) Done http://gerrit.cloudera.org:8080/#/c/20447/37/be/src/util/openssl-util.cc@315 PS37, Line 315: // larger buffers need to be chunked into smaller parts. > line too long (98 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/20447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3902f2b1d95da4d06995cbd687e79c48e16190c9 Gerrit-Change-Number: 20447 Gerrit-PatchSet: 38 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Comment-Date: Mon, 27 Jan 2025 15:58:00 +0000 Gerrit-HasComments: Yes
