Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10394 )
Change subject: PREVIEW: IMPALA-110 (part 1): Refactor PartitionedAggregationNode ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10394/1/be/src/exec/non-grouping-aggregator.cc File be/src/exec/non-grouping-aggregator.cc: http://gerrit.cloudera.org:8080/#/c/10394/1/be/src/exec/non-grouping-aggregator.cc@43 PS1, Line 43: true > why initialized to true? I feel like we should defer changing some of the more subtle details of the logic until a follow-on patch. -- To view, visit http://gerrit.cloudera.org:8080/10394 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e7bb583f54aa4add3738bde7f57cf3511ac567e Gerrit-Change-Number: 10394 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Wed, 23 May 2018 22:32:28 +0000 Gerrit-HasComments: Yes
