Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22404
Change subject: IMPALA-13694: Add ImpalaConnection.__reset_impala_clients method ...................................................................... IMPALA-13694: Add ImpalaConnection.__reset_impala_clients method This patch adds __reset_impala_clients() method in ImpalaConnection. __reset_impala_clients() then simply clear configuration. It is called on each setup_method() to ensure that each EE test uses clean test client. All subclasses of ImpalaTestSuite that declare setup() method are refactored to declare setup_method() instead, to match newer py.test convention. Also implement teardown_method() to complement setup_method(). See "Method and function level setup/teardown" at https://docs.pytest.org/en/stable/how-to/xunit_setup.html. This patch improve BeeswaxConnection and ImpylaHS2Connection to only consider non-REMOVED options as its default options. They lookup for valid (not REMOVED) query options with their own appropriate way, memorized the option names as lowercase string and the values as string. List values are wrapped with double quote. Log in ImpalaConnection.set_configuration_option() is differentiated from how SET query looks. Note that ImpalaTestSuite.run_test_case() modify and restore query option written at .test file by issuing SET query, not by calling ImpalaConnection.set_configuration_option(). It is remain unchanged. Consistently lower case query option everywhere in Impala test code infrastructure. Fixed several tests that has been unknowingly override 'exec_option' vector dimension due to case sensitive mismatch. Also fixed some flake8 issues. Testing: - Pass core tests. Change-Id: Ieb47fec9f384cb58b19fdbd10ff7aa0850ad6277 --- M tests/authorization/test_authorization.py M tests/beeswax/impala_beeswax.py M tests/common/custom_cluster_test_suite.py M tests/common/impala_connection.py M tests/common/impala_test_suite.py M tests/common/test_vector.py M tests/custom_cluster/test_admission_controller.py M tests/custom_cluster/test_hs2_fault_injection.py M tests/custom_cluster/test_kudu.py M tests/custom_cluster/test_mt_dop.py M tests/custom_cluster/test_runtime_filter_aggregation.py M tests/hs2/hs2_test_suite.py M tests/query_test/test_exprs.py M tests/query_test/test_hdfs_caching.py M tests/query_test/test_iceberg.py M tests/query_test/test_insert_behaviour.py M tests/query_test/test_kudu.py M tests/query_test/test_runtime_filters.py 18 files changed, 222 insertions(+), 106 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/22404/1 -- To view, visit http://gerrit.cloudera.org:8080/22404 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ieb47fec9f384cb58b19fdbd10ff7aa0850ad6277 Gerrit-Change-Number: 22404 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]>
