Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22404 )

Change subject: IMPALA-13694: Add ImpalaConnection.__reset_impala_clients method
......................................................................


Patch Set 1:

(3 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/22404/1/tests/common/impala_test_suite.py
File tests/common/impala_test_suite.py:

http://gerrit.cloudera.org:8080/#/c/22404/1/tests/common/impala_test_suite.py@323
PS1, Line 323: t
flake8: U100 Unused argument 'test_method'


http://gerrit.cloudera.org:8080/#/c/22404/1/tests/common/impala_test_suite.py@328
PS1, Line 328: t
flake8: U100 Unused argument 'test_method'


http://gerrit.cloudera.org:8080/#/c/22404/1/tests/query_test/test_hdfs_caching.py
File tests/query_test/test_hdfs_caching.py:

http://gerrit.cloudera.org:8080/#/c/22404/1/tests/query_test/test_hdfs_caching.py@81
PS1, Line 81: (
flake8: E275 missing whitespace after keyword



--
To view, visit http://gerrit.cloudera.org:8080/22404
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb47fec9f384cb58b19fdbd10ff7aa0850ad6277
Gerrit-Change-Number: 22404
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Tue, 28 Jan 2025 02:06:44 +0000
Gerrit-HasComments: Yes

Reply via email to