Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22412 )
Change subject: IMPALA-13571: Calcite Planner: Fix join parsing errors. ...................................................................... Patch Set 2: (6 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22412/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteJniFrontend.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteJniFrontend.java: http://gerrit.cloudera.org:8080/#/c/22412/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteJniFrontend.java@84 PS2, Line 84: private static Pattern TABLE_NOT_FOUND = Pattern.compile(".*\\bTable '(.*)' not found\\b.*", line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/22412/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteJniFrontend.java@87 PS2, Line 87: private static Pattern COLUMN_NOT_FOUND = Pattern.compile(".*\\bColumn '(.*)' not found\\b.*", line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/22412/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteJniFrontend.java@251 PS2, Line 251: throw new UnsupportedFeatureException("Complex column " + m.group(1) + " not supported."); line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/22412/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteJniFrontend.java@258 PS2, Line 258: throw new UnsupportedFeatureException("Complex column " + m.group(1) + " not supported."); line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/22412/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteMetadataHandler.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteMetadataHandler.java: http://gerrit.cloudera.org:8080/#/c/22412/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteMetadataHandler.java@100 PS2, Line 100: List<String> errorTables = populateCalciteSchema(reader_, queryCtx.getFrontend().getCatalog(), line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/22412/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteMetadataHandler.java@241 PS2, Line 241: List<String> errorTables, CalciteJniFrontend.QueryContext queryCtx) throws ImpalaException { line too long (100 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22412 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icd0f68441c84b090ed2cb45de96ccee1054deef5 Gerrit-Change-Number: 22412 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 30 Jan 2025 00:32:07 +0000 Gerrit-HasComments: Yes
