Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22412 )
Change subject: IMPALA-13571: Calcite Planner: Fix join parsing errors. ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/22412/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteMetadataHandler.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteMetadataHandler.java: http://gerrit.cloudera.org:8080/#/c/22412/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteMetadataHandler.java@105 PS4, Line 105: tableVisitor.checkForComplexTable(stmtTableCache_, errorTables, queryCtx); > errorLoader is not getting used. I assume this is supposed to be passed t Gonna reply to both comments here. The same problem still holds that I mentioned in the other comment. The Preconditions check is for loaded tables and failed tables. That Preconditions check can fail due to a race condition (even though the window is very small). So this errorTables should be deleted. Then, I either need to instantiate the StmtMetadataLoader everytime in the for loop below like I currently have, or I can remove the Preconditions check (though I'd have to see if that's dangerous) and call loadTables multiple times. http://gerrit.cloudera.org:8080/#/c/22412/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteMetadataHandler.java@277 PS4, Line 277: StmtMetadataLoader errorLoader = new StmtMetadataLoader( > Ok, but I just realized that line# 103 is creating a new StmtMetadataLoader See above comment on line 105 -- To view, visit http://gerrit.cloudera.org:8080/22412 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icd0f68441c84b090ed2cb45de96ccee1054deef5 Gerrit-Change-Number: 22412 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 04 Feb 2025 05:19:35 +0000 Gerrit-HasComments: Yes
