Surya Hebbar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21683 )

Change subject: IMPALA-13304: Include aggregate instance-level metrics in JSON 
profile
......................................................................


Patch Set 19:

(2 comments)

Thanks a lot for helping with the entire Code Review!

I have fixed the nits now.

Please let me know, if I should approach somebody for the +1.

http://gerrit.cloudera.org:8080/#/c/21683/17/be/src/util/runtime-profile-test.cc
File be/src/util/runtime-profile-test.cc:

http://gerrit.cloudera.org:8080/#/c/21683/17/be/src/util/runtime-profile-test.cc@2251
PS17, Line 2251:
> Sounds good to me.
I have renamed the tests now.


http://gerrit.cloudera.org:8080/#/c/21683/19/be/src/util/runtime-profile.cc
File be/src/util/runtime-profile.cc:

http://gerrit.cloudera.org:8080/#/c/21683/19/be/src/util/runtime-profile.cc@69
PS19, Line 69: (N > M)
> nit: remove this.
Done



--
To view, visit http://gerrit.cloudera.org:8080/21683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I49e18a7a7e1288e3e674e15b6fc86aad60a08214
Gerrit-Change-Number: 21683
Gerrit-PatchSet: 19
Gerrit-Owner: Surya Hebbar <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Kurt Deschler <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Surya Hebbar <[email protected]>
Gerrit-Comment-Date: Thu, 30 Jan 2025 08:56:48 +0000
Gerrit-HasComments: Yes

Reply via email to