Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/21683 )
Change subject: IMPALA-13304: Include aggregate instance-level metrics in JSON profile ...................................................................... Patch Set 17: (1 comment) http://gerrit.cloudera.org:8080/#/c/21683/17/be/src/util/runtime-profile-test.cc File be/src/util/runtime-profile-test.cc: http://gerrit.cloudera.org:8080/#/c/21683/17/be/src/util/runtime-profile-test.cc@2015 PS17, Line 2015: dummy_event_duration This should have been 1ms. Do not want to trigger another unnecessary build, for this small nit. SetUp method was overloaded and overriding empty method was unnecessary, except for clang tidy job warnings failing the build. -- To view, visit http://gerrit.cloudera.org:8080/21683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I49e18a7a7e1288e3e674e15b6fc86aad60a08214 Gerrit-Change-Number: 21683 Gerrit-PatchSet: 17 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Tue, 28 Jan 2025 15:50:08 +0000 Gerrit-HasComments: Yes
