Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22457
Change subject: IMPALA-13727: Fix wrong regex for hostname in test_multiple_blocks_mt_dop ...................................................................... IMPALA-13727: Fix wrong regex for hostname in test_multiple_blocks_mt_dop The test uses r'host=(\S+:[0-9]*)' to match the hosts of all the fragment instances in query profile, i.e. host_list = re.findall(r'host=(\S+:[0-9]*)', result.runtime_profile) This is able to find the instance name in lines like Instance d843c27e276bfa7a:a86450f600000006 (host=name:27002): and get "name:27002" from it. However, the runtime profile we get right after fetching the query result and before closing the query might have a section of total time after the fragment instance host, e.g. Instance d843c27e276bfa7a:a86450f600000006 (host=name:27002):(Total: 19.999ms, non-child: 0.000ns, % non-child: 0.00%) The regex pattern will match "name:27002):Total:" in the string. If not all the instances have this "Total" section, the instance names mismatch and the test will fail. See the query profile attached in the JIRA as an example. Not sure how this happens. Maybe it's not guaranteed that the profile is ready immediately when the last result row is fetched. There might be a delay for the coordinator to process the final update of the profile from executors. I think it's ok to fix the test first. This fixes the regex pattern to be r'\(host=([^:]+:[0-9]*)\)' so it can exactly match the instance name. Tests - Verified the fix locally Change-Id: If70daa344403f2ae8617bf86e7896c2bbfd9e736 --- M tests/query_test/test_scanners.py 1 file changed, 9 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/22457/1 -- To view, visit http://gerrit.cloudera.org:8080/22457 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If70daa344403f2ae8617bf86e7896c2bbfd9e736 Gerrit-Change-Number: 22457 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]>
