Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/22457 )
Change subject: IMPALA-13727: Fix wrong regex for hostname in test_multiple_blocks_mt_dop ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/22457/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22457/2//COMMIT_MSG@24 PS2, Line 24: Not sure how this happens. Maybe it's not guaranteed that the : profile is ready immediately when the last result row is fetched. There : might be a delay for the coordinator to process the final update of the : profile from executors. It would be nice to have a reliable way to get the runtime profile. One issue is the one mentioned in https://github.com/cloudera/impyla/pull/528 - before we close the query, the profile is not final, but if we get it after the query is closed, then the profile may be already discarded. There may be other issues, e.g. I don't know if the coordinator waits for a final profile update from executors before closing the query. A way to solve the before/after close dilemma would be to allow optionally to get the profile in CloseImpalaOperation(), where we can guarantee that the final profile is returned. -- To view, visit http://gerrit.cloudera.org:8080/22457 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If70daa344403f2ae8617bf86e7896c2bbfd9e736 Gerrit-Change-Number: 22457 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 07 Feb 2025 10:36:11 +0000 Gerrit-HasComments: Yes
