Laszlo Gaal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22460
Change subject: IMPALA-13741: Ignore flake8 W504 during precommit quick checks ...................................................................... IMPALA-13741: Ignore flake8 W504 during precommit quick checks bin/jenkins/critique-gerrit-review.py warns about W504:"line break after binary operator" during first-pass precommit checks for new patches submitted for Impala on gerrit.cloudera.org. W504 was created in April 2016, when flake8 changed their opinion about the way line breaks should be handled around binary operators: the accepted way before that date was exactly the opposite. Since the majority of Python code in Impala was created before that date, existing Impala convention is to add the line break after the operator, so W504 does not make sense for Impala. For this reason, this patch disables W504 for flake8 via a command-line parameter passed to flake8 from critique-gerrit-review.py Tested locally. Change-Id: Id118c4a92dcce1b7a315f85c2bcc9afdd5b6b886 --- M bin/jenkins/critique-gerrit-review.py 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/22460/1 -- To view, visit http://gerrit.cloudera.org:8080/22460 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id118c4a92dcce1b7a315f85c2bcc9afdd5b6b886 Gerrit-Change-Number: 22460 Gerrit-PatchSet: 1 Gerrit-Owner: Laszlo Gaal <[email protected]>
