Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22460 )
Change subject: IMPALA-13741: Ignore flake8 W504 during precommit quick checks ...................................................................... Patch Set 1: (1 comment) I generally agree with disabling this check since it contradicts so much of our existing convention. http://gerrit.cloudera.org:8080/#/c/22460/1/bin/jenkins/critique-gerrit-review.py File bin/jenkins/critique-gerrit-review.py: http://gerrit.cloudera.org:8080/#/c/22460/1/bin/jenkins/critique-gerrit-review.py@55 PS1, Line 55: FLAKE8_IGNORE_W504 = "--ignore=W504" I think it'd be better to do this as a flake8 config file - https://flake8.pycqa.org/en/latest/user/configuration.html - so it applies to developers doing local checks as well. -- To view, visit http://gerrit.cloudera.org:8080/22460 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id118c4a92dcce1b7a315f85c2bcc9afdd5b6b886 Gerrit-Change-Number: 22460 Gerrit-PatchSet: 1 Gerrit-Owner: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 06 Feb 2025 16:44:40 +0000 Gerrit-HasComments: Yes
