Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22249 )
Change subject: IMPALA-13201: System Table Queries Execute When Admission Queues are Full ...................................................................... Patch Set 19: (7 comments) http://gerrit.cloudera.org:8080/#/c/22249/19/be/src/scheduling/cluster-membership-mgr-test.cc File be/src/scheduling/cluster-membership-mgr-test.cc: http://gerrit.cloudera.org:8080/#/c/22249/19/be/src/scheduling/cluster-membership-mgr-test.cc@290 PS19, Line 290: << "Actual hostnames: " << actual_hostnames.str(); Space after "Actual hostnames:" isn't needed because actual_hostnames will begin with a space. http://gerrit.cloudera.org:8080/#/c/22249/19/be/src/scheduling/cluster-membership-mgr-test.cc@302 PS19, Line 302: << expected << "' in actual coordinators: " << actual_hostnames.str(); Same here, could be "' in actual coordinators:". http://gerrit.cloudera.org:8080/#/c/22249/15/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/22249/15/be/src/util/webserver.cc@717 PS15, Line 717: LOG(INFO) << "Invalid JWT token provided"; > Nevermind. What was the answer here? I don't understand either. http://gerrit.cloudera.org:8080/#/c/22249/19/common/thrift/ImpalaInternalService.thrift File common/thrift/ImpalaInternalService.thrift: http://gerrit.cloudera.org:8080/#/c/22249/19/common/thrift/ImpalaInternalService.thrift@236 PS19, Line 236: 14: optional bool only_coordinators Should have a comment. http://gerrit.cloudera.org:8080/#/c/22249/19/docs/topics/impala_admission_config.xml File docs/topics/impala_admission_config.xml: http://gerrit.cloudera.org:8080/#/c/22249/19/docs/topics/impala_admission_config.xml@187 PS19, Line 187: To use an <codeph><onlyCoordinators></codeph> request pool, simple set the typo: "simple" should be "simply", but I'd rather remove it. http://gerrit.cloudera.org:8080/#/c/22249/19/docs/topics/impala_admission_config.xml@196 PS19, Line 196: Caution: care must be taken when naming the <codeph><onlyCoordinators></codeph> Why does this happen? http://gerrit.cloudera.org:8080/#/c/22249/16/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/22249/16/tests/custom_cluster/test_admission_controller.py@1949 PS16, Line 1949: self._start_impala_cluster( : options=[ : "--impalad_args=s{}".format(impalad_admission_ctrl_config_args( : fs_allocation_file="fair-scheduler-onlycoords.xml", : llama_site_file="llama-site-onlycoords.xml"))], : add_impalads=True, : cluster_size=6, : num_coordinators=1, : use_exclusive_coordinators=True, : wait_for_backends=False, : workload_mgmt=True) > I'm not quite sure how adding another parameter to the CustomClusterTestSui What you're running up against here is that add_impalads was hacked in to support adding a 2nd cluster that doesn't know about the other cluster. That's why it has the additional logic at https://github.com/apache/impala/blob/master/bin/start-impala-cluster.py#L1171-L1174. If test_shared_catalogd still works, I guess we can clean this up in a separate ticket. -- To view, visit http://gerrit.cloudera.org:8080/22249 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5e0e64db92bdbf80f8b5bd85d001ffe4c8c9ffda Gerrit-Change-Number: 22249 Gerrit-PatchSet: 19 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 11 Feb 2025 22:08:47 +0000 Gerrit-HasComments: Yes
