Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22249 )
Change subject: IMPALA-13201: System Table Queries Execute When Admission Queues are Full ...................................................................... Patch Set 20: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/22249/19/common/thrift/ImpalaInternalService.thrift File common/thrift/ImpalaInternalService.thrift: http://gerrit.cloudera.org:8080/#/c/22249/19/common/thrift/ImpalaInternalService.thrift@236 PS19, Line 236: // Specifies the state of the onlyCoordinators configuration element for a request pool. > Good catch. Done Ack http://gerrit.cloudera.org:8080/#/c/22249/20/common/thrift/ImpalaInternalService.thrift File common/thrift/ImpalaInternalService.thrift: http://gerrit.cloudera.org:8080/#/c/22249/20/common/thrift/ImpalaInternalService.thrift@238 PS20, Line 238: // which means that pool only considers resources from the coordinator nodes and queies typo: queies -> queries http://gerrit.cloudera.org:8080/#/c/22249/19/docs/topics/impala_admission_config.xml File docs/topics/impala_admission_config.xml: http://gerrit.cloudera.org:8080/#/c/22249/19/docs/topics/impala_admission_config.xml@196 PS19, Line 196: Caution: care must be taken when naming the <codeph><onlyCoordinators></codeph> > It's a combination of planning and scheduling. Impala allows for specifyin Ack -- To view, visit http://gerrit.cloudera.org:8080/22249 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5e0e64db92bdbf80f8b5bd85d001ffe4c8c9ffda Gerrit-Change-Number: 22249 Gerrit-PatchSet: 20 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 12 Feb 2025 00:25:17 +0000 Gerrit-HasComments: Yes
