Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22249 )
Change subject: IMPALA-13201: System Table Queries Execute When Admission Queues are Full ...................................................................... Patch Set 25: (4 comments) http://gerrit.cloudera.org:8080/#/c/22249/24/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/22249/24/fe/src/main/java/org/apache/impala/service/Frontend.java@2201 PS24, Line 2201: coordOnlyRequestPool = > I prefer camel case since it's Java. I wasn't sure which is correct since Done http://gerrit.cloudera.org:8080/#/c/22249/25/java/yarn-extras/src/main/java/org/apache/impala/yarn/server/resourcemanager/scheduler/fair/AllocationFileLoaderService.java File java/yarn-extras/src/main/java/org/apache/impala/yarn/server/resourcemanager/scheduler/fair/AllocationFileLoaderService.java: http://gerrit.cloudera.org:8080/#/c/22249/25/java/yarn-extras/src/main/java/org/apache/impala/yarn/server/resourcemanager/scheduler/fair/AllocationFileLoaderService.java@62 PS25, Line 62: : public static final Log LOG = LogFactory.getLog( : AllocationFileLoaderService.class.getName()); : nit: clean this trailing whitespace. Sorry I miss this before. http://gerrit.cloudera.org:8080/#/c/22249/24/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/22249/24/tests/custom_cluster/test_admission_controller.py@1824 PS24, Line 1824: rch(r'\n\s+Executor group 1:\n\s+Verdict: (.*?)\n', profile) : assert fe_verdict, "No fr > Good idea. I modified the code to capture the entire verdict and then do a Done http://gerrit.cloudera.org:8080/#/c/22249/24/tests/custom_cluster/test_admission_controller.py@1996 PS24, Line 1996: cluster_size=1, > Both places are adding executors. The @CustomClusterTestSuite annotation s I think use_exclusive_coordinators will be ignored here. https://github.com/apache/impala/blob/c9e9f86c0536f0991f70613675bbcfbbccc6a324/bin/start-impala-cluster.py#L1145 So maybe drop it? -- To view, visit http://gerrit.cloudera.org:8080/22249 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5e0e64db92bdbf80f8b5bd85d001ffe4c8c9ffda Gerrit-Change-Number: 22249 Gerrit-PatchSet: 25 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 12 Feb 2025 23:36:26 +0000 Gerrit-HasComments: Yes
