Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22487
Change subject: IMPALA-13758: Use context manager in ImpalaTestSuite.change_database ...................................................................... IMPALA-13758: Use context manager in ImpalaTestSuite.change_database ImpalaTestSuite.change_database is responsible to point impala client to database under test. However, it left client pointing to that database after the test without reverting them back to default database. This patch does the reversal by changing ImpalaTestSuite.change_database to use context manager. Removed unused test fixtures and fixed several flake8 issues in modified test files. Testing: - Moved nested-types-subplan-single-node.test. This allows the test framework to point to the right tpch_nested* database. - Pass exhaustive test except IMPALA-13752 and IMPALA-13761. They will be fixed in separate patch. Change-Id: I75bec7403cc302728a630efe3f95e852a84594e2 --- R testdata/workloads/tpch_nested/queries/QueryTest/nested-types-subplan-single-node.test M tests/common/impala_test_suite.py M tests/common/test_vector.py M tests/conftest.py M tests/custom_cluster/test_admission_controller.py M tests/custom_cluster/test_blacklisted_dbs_and_tables.py M tests/custom_cluster/test_data_cache.py M tests/failure/test_failpoints.py M tests/query_test/test_aggregation.py M tests/query_test/test_cancellation.py M tests/query_test/test_mem_usage_scaling.py M tests/query_test/test_mt_dop.py M tests/query_test/test_nested_types.py M tests/query_test/test_runtime_filters.py M tests/query_test/test_scanners.py M tests/query_test/test_tablesample.py M tests/util/cancel_util.py 17 files changed, 206 insertions(+), 149 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/22487/1 -- To view, visit http://gerrit.cloudera.org:8080/22487 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I75bec7403cc302728a630efe3f95e852a84594e2 Gerrit-Change-Number: 22487 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]>
