Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22487 )
Change subject: IMPALA-13758: Use context manager in ImpalaTestSuite.change_database ...................................................................... Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/22487/3/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22487/3/tests/common/impala_test_suite.py@1046 PS3, Line 1046: generator I think "context manager" would describe its function better in this case. http://gerrit.cloudera.org:8080/#/c/22487/3/tests/query_test/test_cancellation.py File tests/query_test/test_cancellation.py: http://gerrit.cloudera.org:8080/#/c/22487/3/tests/query_test/test_cancellation.py@115 PS3, Line 115: n Nit: iterations -- To view, visit http://gerrit.cloudera.org:8080/22487 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75bec7403cc302728a630efe3f95e852a84594e2 Gerrit-Change-Number: 22487 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 19 Feb 2025 07:58:53 +0000 Gerrit-HasComments: Yes
