Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10490 )
Change subject: IMPALA-4970: Record identity of largest latency ExecQueryFInstances() RPC per query. ...................................................................... Patch Set 2: (9 comments) http://gerrit.cloudera.org:8080/#/c/10490/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10490/2//COMMIT_MSG@7 PS2, Line 7: IMPALA-4970: Record identity of largest latency ExecQueryFInstances() RPC per : query. nit: Commit message titles have to be in one line, so if it exceeds the char limit, it's okay, but only the titles. http://gerrit.cloudera.org:8080/#/c/10490/2//COMMIT_MSG@10 PS2, Line 10: Added code to track the slowest RPC to BackendState and identifying that node : as the slowest node. nit: Tracked the slowest ExecQueryFInstances() RPC to executors and added the identity of that executor to the RuntimeProfile. http://gerrit.cloudera.org:8080/#/c/10490/2//COMMIT_MSG@12 PS2, Line 12: Can you add a note saying how you manually tested it? Add "Testing: ..." http://gerrit.cloudera.org:8080/#/c/10490/2/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/10490/2/be/src/runtime/coordinator.cc@357 PS2, Line 357: INT_MIN This can be 0, since we never expect a negative latency. http://gerrit.cloudera.org:8080/#/c/10490/2/be/src/runtime/coordinator.cc@357 PS2, Line 357: int max_latency = INT_MIN; Move this into the for loop just above L365 to limit the scope of its lifetime. http://gerrit.cloudera.org:8080/#/c/10490/2/be/src/runtime/coordinator.cc@367 PS2, Line 367: max_latency_host = backend_state->impalad_address().hostname + ":" + std::to_string(backend_state->impalad_address().port); nit: long line. Keep lines to 90 chars, and make it a multi-line statement if it doesn't fit. http://gerrit.cloudera.org:8080/#/c/10490/2/be/src/runtime/coordinator.cc@367 PS2, Line 367: backend_state->impalad_address().hostname + ":" + std::to_string(backend_state->impalad_address().port); use the TNetworkAddressToString() utility here to print the impalad_address() Eg: Look at L686 http://gerrit.cloudera.org:8080/#/c/10490/2/be/src/runtime/coordinator.cc@373 PS2, Line 373: query_profile_->AddInfoString( : "Slowest Host", max_latency_host); This can fit on one line. http://gerrit.cloudera.org:8080/#/c/10490/2/be/src/runtime/coordinator.cc@374 PS2, Line 374: Slowest Host The previous line says "Backend startup latencies". So lets keep the terms consistent. Maybe change this to "Slowest backend to startup" or something similar. -- To view, visit http://gerrit.cloudera.org:8080/10490 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf9ce0d087c91c2e92ba5be08c96cc5364ae38dc Gerrit-Change-Number: 10490 Gerrit-PatchSet: 2 Gerrit-Owner: Rahul Shivu Mahadev <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Thu, 24 May 2018 21:03:14 +0000 Gerrit-HasComments: Yes
