Rahul Shivu Mahadev has posted comments on this change. ( http://gerrit.cloudera.org:8080/10490 )
Change subject: IMPALA-4970: Record identity of largest latency ExecQueryFInstances() ...................................................................... Patch Set 3: (9 comments) http://gerrit.cloudera.org:8080/#/c/10490/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10490/2//COMMIT_MSG@7 PS2, Line 7: IMPALA-4970: Record identity of largest latency ExecQueryFInstances() : > nit: Commit message titles have to be in one line, so if it exceeds the cha Done http://gerrit.cloudera.org:8080/#/c/10490/2//COMMIT_MSG@10 PS2, Line 10: added the identity of that executor to the RuntimeProfile. : > nit: Tracked the slowest ExecQueryFInstances() RPC to executors and added t Done http://gerrit.cloudera.org:8080/#/c/10490/2//COMMIT_MSG@12 PS2, Line 12: Testing: Manually tested to verify working. > Can you add a note saying how you manually tested it? Done http://gerrit.cloudera.org:8080/#/c/10490/2/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/10490/2/be/src/runtime/coordinator.cc@357 PS2, Line 357: int max_latency = 0; > Move this into the for loop just above L365 to limit the scope of its lifet I won't be able to do that as we need to iterate and find the max latency http://gerrit.cloudera.org:8080/#/c/10490/2/be/src/runtime/coordinator.cc@357 PS2, Line 357: 0; > This can be 0, since we never expect a negative latency. Done http://gerrit.cloudera.org:8080/#/c/10490/2/be/src/runtime/coordinator.cc@367 PS2, Line 367: TNetworkAddressToString(backend_state->impalad_address()); > use the TNetworkAddressToString() utility here to print the impalad_address Done http://gerrit.cloudera.org:8080/#/c/10490/2/be/src/runtime/coordinator.cc@367 PS2, Line 367: max_latency_host = TNetworkAddressToString(backend_state->impalad_address()); > nit: long line. Keep lines to 90 chars, and make it a multi-line statement Done http://gerrit.cloudera.org:8080/#/c/10490/2/be/src/runtime/coordinator.cc@374 PS2, Line 374: n UpdateExec > The previous line says "Backend startup latencies". So lets keep the terms Done http://gerrit.cloudera.org:8080/#/c/10490/2/be/src/runtime/coordinator.cc@373 PS2, Line 373: query_profile_->AddInfoString("Slowest Backend to startup", max_latency_host); : return UpdateExecState(status, nullptr > This can fit on one line. Done -- To view, visit http://gerrit.cloudera.org:8080/10490 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf9ce0d087c91c2e92ba5be08c96cc5364ae38dc Gerrit-Change-Number: 10490 Gerrit-PatchSet: 3 Gerrit-Owner: Rahul Shivu Mahadev <rahul.maha...@cloudera.com> Gerrit-Reviewer: Rahul Shivu Mahadev <rahul.maha...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Thu, 24 May 2018 21:59:28 +0000 Gerrit-HasComments: Yes
