Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22482 )
Change subject: IMPALA-13751: Fix runtime-profile-test failure since IMPALA-13304 ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/22482/8/be/src/util/runtime-profile-test.cc File be/src/util/runtime-profile-test.cc: http://gerrit.cloudera.org:8080/#/c/22482/8/be/src/util/runtime-profile-test.cc@2034 PS8, Line 2034: // Retry until maximum setup retries : if (!EVENT_COMPLETENESS && missing_event_instances_expected.size() <= 0 : && setup_retries < MAX_SETUP_RETRIES) { > As I said, there is very less to no reason to believe the test will not gen In that case, please add following else block: } else if (setup_retries >= MAX_SETUP_RETRIES) { ASSERT_TRUE(false) << "SetUp fail to create desired test case after " << MAX_SETUP_RETRIES << " tries. This should not happen."; } -- To view, visit http://gerrit.cloudera.org:8080/22482 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If04744e215cac79f255b3d73c3e91e873c13749a Gerrit-Change-Number: 22482 Gerrit-PatchSet: 8 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Thu, 20 Feb 2025 00:27:06 +0000 Gerrit-HasComments: Yes
