Surya Hebbar has uploaded a new patch set (#10). (
http://gerrit.cloudera.org:8080/22482 )
Change subject: IMPALA-13751: Fix runtime-profile-test failure since
IMPALA-13304
......................................................................
IMPALA-13751: Fix runtime-profile-test failure since IMPALA-13304
This patch fixes the flaky tests added to the 'runtime-profile-test'
in IMPALA-13304.
The following possible causes have been fixed.
- Lexical errors present while defining example event sequence labels
- Edge cases providing invalid randomization ranges
- Improper re-allocation of instance timestamps
- Inconsistent sleep timers during event sequence generation
The test fixture's coverage for cases of complete and missing events
have been refactored into a common validation method.
To cover different scenarios of missing events across instances for
sorting and alignment randomized tests have been kept.
For simulating missing events, the test fixture uses bernoulli's
distribution with two possible probability values 0.5 and 0.8.
This generates missing events with an approximate certainity of ~99.99%.
Also, irrespective of the presence of missing events the test runs
successfully.
Still, to ensure even more certainity(>99.99%), now the test fixture
retries the setup for a maximum of 3 times.
The randomly generated values are also included as parameters within
the JUnitXML.
Tested locally with high parallelism and resource exhaustion using
GNU's parallel.
i.e. parallel -j 100 <test command> ::: {1..100}
Change-Id: If04744e215cac79f255b3d73c3e91e873c13749a
---
M be/src/util/runtime-profile-test.cc
M be/src/util/runtime-profile.cc
2 files changed, 110 insertions(+), 118 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/22482/10
--
To view, visit http://gerrit.cloudera.org:8080/22482
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If04744e215cac79f255b3d73c3e91e873c13749a
Gerrit-Change-Number: 22482
Gerrit-PatchSet: 10
Gerrit-Owner: Surya Hebbar <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Laszlo Gaal <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Surya Hebbar <[email protected]>
