Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/22508 )
Change subject: IMPALA-13770: Updating Iceberg tables with UDFs crashes Impala ...................................................................... Patch Set 2: (2 comments) Thanks for the investigation and the quick fix! http://gerrit.cloudera.org:8080/#/c/22508/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-update-basic.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-update-basic.test: http://gerrit.cloudera.org:8080/#/c/22508/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-update-basic.test@410 PS2, Line 410: create table update_with_udf(int_col INT) : stored by iceberg : tblproperties ('format-version'='2'); I think it would be best to use a non-empty table. You could use an already existing one from this test file (e.g. ice_alltypes). The content would remain the same anyway, so it would not require rewriting the other test cases. http://gerrit.cloudera.org:8080/#/c/22508/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-update-basic.test@413 PS2, Line 413: ==== : ---- QUERY : update update_with_udf set int_col = identity(int_col); : ---- TYPES : INT : ==== Could you please verify the results of a non-empty table after the update? Since the results would be identical, you could also check that the update was actually executed in test_iceberg.py by checking the number of snapshots in the table. For example this could go around L210: UPDATE ice_alltypes SET int_col = identity(int_col); ---- DML_RESULTS: ice_alltypes false,0,111,0,0,234,123.00,2023-11-07,2000-01-01 00:00:00,'IMPALA','zerob' true,3,222,1,1,NULL,NULL,2023-11-08,2001-01-01 01:01:01,'ICEBERG','oneb' ---- TYPES BOOLEAN,INT,BIGINT,FLOAT,DOUBLE,DECIMAL,DECIMAL,DATE,TIMESTAMP,STRING,BINARY ---- RUNTIME_PROFILE NumModifiedRows: 2 NumDeletedRows: 2 ==== -- To view, visit http://gerrit.cloudera.org:8080/22508 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id86638c8d6d86062c68cc9d708ec9c7b0a4e95eb Gerrit-Change-Number: 22508 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 20 Feb 2025 10:37:40 +0000 Gerrit-HasComments: Yes
