Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22508 )
Change subject: IMPALA-13770: Updating Iceberg tables with UDFs crashes Impala ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/22508/2/be/src/exec/multi-table-sink.h File be/src/exec/multi-table-sink.h: http://gerrit.cloudera.org:8080/#/c/22508/2/be/src/exec/multi-table-sink.h@42 PS2, Line 42: virtual > nit: virtual is redundant here I like to always write 'virtual' for completeness and so that the reader immediately knows it is a virtual function. http://gerrit.cloudera.org:8080/#/c/22508/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-update-basic.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-update-basic.test: http://gerrit.cloudera.org:8080/#/c/22508/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-update-basic.test@410 PS2, Line 410: # values can also be updated successfully. This is because the crash happens after the : # query is closed, when releasing resources. This test is a valid regression test because : # even if it passes, there will be a > I think we should use temporary tables for DML cases even if the DML statem I created a temp table and filled it with some explicit values. http://gerrit.cloudera.org:8080/#/c/22508/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-update-basic.test@413 PS2, Line 413: # there will be a minidump in the build artifacts, so the build will be marked FAILED. : create function if not exists identity(int) returns int location 'UDF_LOCATION' symbol='Identity'; : create table update_with_udf(int_col INT) : stored by iceberg : tblproperties ('format-version'='2'); : inse > Could you please verify the results of a non-empty table after the update? Done http://gerrit.cloudera.org:8080/#/c/22508/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-update-basic.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-update-basic.test: http://gerrit.cloudera.org:8080/#/c/22508/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-update-basic.test@422 PS3, Line 422: ---- DML_RESULTS: single_col I thought I'd corrected it... Will do in the next patch. -- To view, visit http://gerrit.cloudera.org:8080/22508 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id86638c8d6d86062c68cc9d708ec9c7b0a4e95eb Gerrit-Change-Number: 22508 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 20 Feb 2025 12:31:02 +0000 Gerrit-HasComments: Yes
