Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22531 )
Change subject: IMPALA-13785: test_catalog_tables_stats_legacy_catalog and test_catalog_tables_stats_local_catalog seem to be flaky in the exhaustive build ...................................................................... Patch Set 1: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/22531/1/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java: http://gerrit.cloudera.org:8080/#/c/22531/1/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@478 PS1, Line 478: long memUsageEstimate = stats.numFiles * PER_FD_MEM_USAGE_BYTES + : stats.numBlocks * PER_BLOCK_MEM_USAGE_BYTES; I think we should improve this in the future to account for cached Iceberg objects. http://gerrit.cloudera.org:8080/#/c/22531/1/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@481 PS1, Line 481: setNumFiles(stats.numFiles); It's not revealed by the test. But the total number of blocks and total file size are also missing. We can get them in catalogd WebUI -> /catalog, then click any item in the Metrics column. For HDFS tables, more metrics are shown there. -- To view, visit http://gerrit.cloudera.org:8080/22531 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I686e0e32b36ace4c5a8c9eeb715148c98521252a Gerrit-Change-Number: 22531 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Tue, 25 Feb 2025 02:29:44 +0000 Gerrit-HasComments: Yes
