Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22531 )
Change subject: IMPALA-13785: Deflake test_catalog_tables_stats in exhaustive build ...................................................................... Patch Set 2: (4 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/22531/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22531/1//COMMIT_MSG@7 PS1, Line 7: Deflake test_catalog_tables_stats in exhaustive build > nit: Title can be shorter: Done http://gerrit.cloudera.org:8080/#/c/22531/1//COMMIT_MSG@15 PS1, Line 15: * executed the tests in the title in exhaustive mode > I tested this patch locally and it works. Done http://gerrit.cloudera.org:8080/#/c/22531/1/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java: http://gerrit.cloudera.org:8080/#/c/22531/1/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@478 PS1, Line 478: getHostIndex(), Preconditions.checkNotNull(icebergFiles), : Utils.requiresDataFilesInTableLocation(t > I think we should improve this in the future to account for cached Iceberg I agree, opened IMPALA-13794 to track this. http://gerrit.cloudera.org:8080/#/c/22531/1/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@481 PS1, Line 481: fileStore_ = new IcebergContentFileStore( > It's not revealed by the test. But the total number of blocks and total fil Added these metrics for Iceberg tables, also added tests for them. -- To view, visit http://gerrit.cloudera.org:8080/22531 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I686e0e32b36ace4c5a8c9eeb715148c98521252a Gerrit-Change-Number: 22531 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 26 Feb 2025 15:32:28 +0000 Gerrit-HasComments: Yes
