Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10517 )
Change subject: IMPALA-7071: make get_fs_path() idempotent ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/10517/1/tests/infra/test_utils.py File tests/infra/test_utils.py: http://gerrit.cloudera.org:8080/#/c/10517/1/tests/infra/test_utils.py@20 PS1, Line 20: import pytest > You shouldn't need this. Done http://gerrit.cloudera.org:8080/#/c/10517/1/tests/infra/test_utils.py@25 PS1, Line 25: class TestUtils(ImpalaTestSuite): > Is there a reason why we need a class here, or inheritance from the ImpalaT Apparently not. -- To view, visit http://gerrit.cloudera.org:8080/10517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I10c7cbb36119883718e60660db2ac7313f14d388 Gerrit-Change-Number: 10517 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Fri, 25 May 2018 18:51:55 +0000 Gerrit-HasComments: Yes
