David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/10517 )
Change subject: IMPALA-7071: make get_fs_path() idempotent ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10517/1/tests/infra/test_utils.py File tests/infra/test_utils.py: http://gerrit.cloudera.org:8080/#/c/10517/1/tests/infra/test_utils.py@25 PS1, Line 25: path = "/fake-warehouse" > Apparently not. Top level test functions are perfectly acceptable, and in fact preferred for simple, straightforward unit tests like this. -- To view, visit http://gerrit.cloudera.org:8080/10517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I10c7cbb36119883718e60660db2ac7313f14d388 Gerrit-Change-Number: 10517 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Hecht <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Fri, 25 May 2018 18:54:16 +0000 Gerrit-HasComments: Yes
