Noemi Pap-Takacs has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22459 )

Change subject: IMPALA-13611: Add interop tests for Iceberg tables
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22459/1/tests/stress/test_update_stress.py
File tests/stress/test_update_stress.py:

http://gerrit.cloudera.org:8080/#/c/22459/1/tests/stress/test_update_stress.py@226
PS1, Line 226: ve_client.close()
> It's hard to tell what is balanced in this situation. My observation is tha
Yes, Hive updater should be balanced with Impala deleter, my mistake.
If we can be confident that Hive can do at least one update, then this could 
work. I know it is hard to find good timing or guarantee anything in this 
nondeterministic case. Just make sure we do not lock out Hive updates.
Do you think it would make sense to check that the last row we deleted was 
bigger than 0, meaning that Hive could update it least once?



--
To view, visit http://gerrit.cloudera.org:8080/22459
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2ee6d3354c3b11264c5e3ded9826831e3962a98
Gerrit-Change-Number: 22459
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <pro...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Feb 2025 14:53:52 +0000
Gerrit-HasComments: Yes

Reply via email to