Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/22459 )
Change subject: IMPALA-13611: Add interop tests for Iceberg tables ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/22459/1/tests/stress/test_update_stress.py File tests/stress/test_update_stress.py: http://gerrit.cloudera.org:8080/#/c/22459/1/tests/stress/test_update_stress.py@226 PS1, Line 226: ve_client.close() > Yes, Hive updater should be balanced with Impala deleter, my mistake. I did some experiments with checking by waiting for Hive to do at least one update, but I have the feeling that with this approach I technically did a synchronization, and I think, the core of this test is to do concurrent operations without additional synchronization, just rely on the Iceberg table's concurrency model. Even if it's theoretically possible that Hive's writing is missed, I think the only thing that we should do here is to avoid the direct lock-out of each writer by shifting their timing. -- To view, visit http://gerrit.cloudera.org:8080/22459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2ee6d3354c3b11264c5e3ded9826831e3962a98 Gerrit-Change-Number: 22459 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Comment-Date: Fri, 14 Mar 2025 13:31:00 +0000 Gerrit-HasComments: Yes
