Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/22588 )
Change subject: IMPALA-13812: Fail query for certain errors related to AI functions ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/22588/4/be/src/exprs/ai-functions.cc File be/src/exprs/ai-functions.cc: http://gerrit.cloudera.org:8080/#/c/22588/4/be/src/exprs/ai-functions.cc@83 PS4, Line 83: return StringVal::null(); \ > If we're setting the error status of the FunctionContext, can we return Str Done http://gerrit.cloudera.org:8080/#/c/22588/4/be/src/exprs/ai-functions.cc@262 PS4, Line 262: // Return a string with the invalid prompt error message instead of failing > We could explore this later I think, so okay to not fail the query for now? Yeah, I think it is okay, like "select 1/0", returns an "inf" string instead of failing the query. I also added a comment here noting that we may reconsider later. http://gerrit.cloudera.org:8080/#/c/22588/4/be/src/exprs/ai-functions.cc@347 PS4, Line 347: return StringVal::null(); > Same question here, we could return StringVal::null() unless we need the re Done -- To view, visit http://gerrit.cloudera.org:8080/22588 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I639e48e64d62f7990cf9a3c35a59a0ee3a2c64e0 Gerrit-Change-Number: 22588 Gerrit-PatchSet: 5 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 11 Mar 2025 06:42:07 +0000 Gerrit-HasComments: Yes
