Yida Wu has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/22588 )
Change subject: IMPALA-13812: Fail query for certain errors related to AI functions ...................................................................... IMPALA-13812: Fail query for certain errors related to AI functions The ai_generate_text() and ai_generate_text_default() functions return error message as a result (string) which could be misleading in some cases. This patch fixes this issue by setting the error in the context as a udf error, causing the query to fail in cases of configuration related errors or http errors when accessing the AI endpoint. Tests: Ran core tests. Added custom testcase TestAIGenerateText for failure cases with ai_generate_text_default(). Added testcase TestExprs.test_ai_generate_text_exprs for failure cases with ai_generate_text(). Change-Id: I639e48e64d62f7990cf9a3c35a59a0ee3a2c64e0 --- M be/src/exprs/ai-functions-ir.cc M be/src/exprs/ai-functions.cc M be/src/exprs/ai-functions.h M be/src/exprs/expr-test.cc M fe/src/main/java/org/apache/impala/service/JniFrontend.java A testdata/workloads/functional-query/queries/QueryTest/ai_generate_text_exprs.test M testdata/workloads/functional-query/queries/QueryTest/exprs.test A tests/custom_cluster/test_ai_generate_text.py M tests/query_test/test_exprs.py 9 files changed, 259 insertions(+), 54 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/22588/6 -- To view, visit http://gerrit.cloudera.org:8080/22588 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I639e48e64d62f7990cf9a3c35a59a0ee3a2c64e0 Gerrit-Change-Number: 22588 Gerrit-PatchSet: 6 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]>
