Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10503 )
Change subject: IMPALA-6812: Fix flaky Kudu scan tests ...................................................................... Patch Set 1: > I'm sympathetic to the problem that people may still encounter > these test failures if they run the tests through a means other > than run-all-tests.sh > Perhaps one option is to make kudu_read_mode a query option, so that it can be set in the query options by the python code. Thomas, can you think of any meaningful Impala/Kudu integration/functional testing that we'll miss out if we change the tests to all rn with READ_AT_SNAPSHOT. It does seem like we need to enable this in order to get predictable scan results, but I also agree with Tim that it's best to test in the way most similar to the defaults. -- To view, visit http://gerrit.cloudera.org:8080/10503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70df84f2cbc663107f2ad029565d3c15bdfbd47c Gerrit-Change-Number: 10503 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 30 May 2018 16:42:44 +0000 Gerrit-HasComments: No
