Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22705 )
Change subject: POC: fix Yarn+Hive+Tez startup with JDK17 ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/22705/3/bin/impala-config-java.sh File bin/impala-config-java.sh: http://gerrit.cloudera.org:8080/#/c/22705/3/bin/impala-config-java.sh@18 PS3, Line 18: IMPALA_JDK_VERSION We start accumulating multiple env var related to java. It might be possible to simplify/remove some of them. Among them, and new in this patch, are: IMPALA_JDK_VERSION IMPALA_JDK_VERSION_NUM IMPALA_JDK9PLUS_JAVA_TOOL_OPTIONS IMPALA_JAVA_HOME_OVERRIDE UBUNTU_JAVA_VERSION REDHAT_JAVA_VERSION TEST_JDK_VERSION Printing the sourced value here will be nice to have for debugging. http://gerrit.cloudera.org:8080/#/c/22705/3/bin/set-jdk9plus-java-tool-options.sh File bin/set-jdk9plus-java-tool-options.sh: http://gerrit.cloudera.org:8080/#/c/22705/3/bin/set-jdk9plus-java-tool-options.sh@59 PS3, Line 59: IMPALA_JDK9PLUS_JAVA_TOOL_OPTIONS A more generic env var name that will be empty if JDK < 9 is probably better. Perhaps IMPALA_JAVA_TOOL_OPTIONS? http://gerrit.cloudera.org:8080/#/c/22705/3/testdata/bin/run-hive-server.sh File testdata/bin/run-hive-server.sh: http://gerrit.cloudera.org:8080/#/c/22705/3/testdata/bin/run-hive-server.sh@37 PS3, Line 37: if (( IMPALA_JDK_VERSION_NUM > 8 )); then : . $IMPALA_HOME/bin/set-jdk9plus-java-tool-options.sh : export JAVA_TOOL_OPTIONS="$IMPALA_JDK9PLUS_JAVA_TOOL_OPTIONS ${JAVA_TOOL_OPTIONS-}" : fi This is duplicated in multiple places. Can this be unified in impala-config-java.sh? -- To view, visit http://gerrit.cloudera.org:8080/22705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If58b64a21d14a4a55b12dfe9ea0b9c3d5fe9c9cf Gerrit-Change-Number: 22705 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 28 Mar 2025 13:50:26 +0000 Gerrit-HasComments: Yes
