Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/22705 )
Change subject: POC: fix Yarn+Hive+Tez startup with JDK17 ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/22705/3/bin/impala-config-java.sh File bin/impala-config-java.sh: http://gerrit.cloudera.org:8080/#/c/22705/3/bin/impala-config-java.sh@18 PS3, Line 18: IMPALA_JDK_VERSION > We start accumulating multiple env var related to java. It might be possibl About simplification: I think that we should clean things up when Java 8 support is dropped and the default moves to 17 The system java version is generally obvious from the logs, but I can print it if needed. http://gerrit.cloudera.org:8080/#/c/22705/3/bin/set-jdk9plus-java-tool-options.sh File bin/set-jdk9plus-java-tool-options.sh: http://gerrit.cloudera.org:8080/#/c/22705/3/bin/set-jdk9plus-java-tool-options.sh@59 PS3, Line 59: > A more generic env var name that will be empty if JDK < 9 is probably bette Done http://gerrit.cloudera.org:8080/#/c/22705/3/testdata/bin/run-hive-server.sh File testdata/bin/run-hive-server.sh: http://gerrit.cloudera.org:8080/#/c/22705/3/testdata/bin/run-hive-server.sh@37 PS3, Line 37: . $IMPALA_HOME/bin/set-impala-java-tool-options.sh : export JAVA_TOOL_OPTIONS="$IMPALA_JAVA_TOOL_OPTIONS ${JAVA_TOOL_OPTIONS-}" : : if > This is duplicated in multiple places. simplified it a bit I don't want to set JAVA_TOOL_OPTIONS in all cases to avoid unneeded side effects, for example in bin/create-test-configuration.sh -- To view, visit http://gerrit.cloudera.org:8080/22705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If58b64a21d14a4a55b12dfe9ea0b9c3d5fe9c9cf Gerrit-Change-Number: 22705 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Sat, 29 Mar 2025 22:33:17 +0000 Gerrit-HasComments: Yes
