Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10525 )
Change subject: IMPALA-6714: [DOCS] ORC file format support ...................................................................... Patch Set 1: (5 comments) > Patch Set 1: > > (1 comment) http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_orc.xml File docs/topics/impala_orc.xml: http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_orc.xml@93 PS1, Line 93: If you do not have an existing data file to use, begin by creating one in the appropriate format. > The example below should be enough, remove. OK. This is the same as other formats' docs. Do you think they should all be removed? http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_orc.xml@133 PS1, Line 133: select * from > Could you make all SQL keywords in uppercase as in the Hive examples below? Sure http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_orc.xml@152 PS1, Line 152: Enabling Compression for ORC Tables > This section deals mostly with Hive - is there a Hive document that could b I think it's reasonable. There're no details examples in the official site of ORC. For example, https://orc.apache.org/docs/hive-ddl.html http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_orc.xml@260 PS1, Line 260: Most of the types have the same name in Impala except the BINARY type is STRING type in Impala, : and the DATE type is not supported in Impala. > Turn into list (or box, similar to what Parquet has) Sure http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_orc.xml@269 PS1, Line 269: For example, > Add examples of what works, and one which doesn't. Include exception text. Sure -- To view, visit http://gerrit.cloudera.org:8080/10525 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1ee23ed844653c274babdce5a332dbe5c79b630 Gerrit-Change-Number: 10525 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Alex Rodoni <[email protected]> Gerrit-Reviewer: Balazs Jeszenszky <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 31 May 2018 22:03:03 +0000 Gerrit-HasComments: Yes
